Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function arguments to start() #663

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add function arguments to start() #663

wants to merge 1 commit into from

Conversation

naomirookout
Copy link
Contributor

No description provided.

naomirookout
naomirookout commented Mar 1, 2023
View reviewed changes
docs/python-setup.mdx
@@ -55,6 +55,8 @@ start(token=None,
git_commit=None,
git_origin=None,
fork=None,
sources=None,
quiet=None,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if this should be False or None

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the code :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None is good

@LiranLast
Copy link
Member

Did you review the other SDKs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElDuderinos ElDuderinos ElDuderinos left review comments

@LiranLast LiranLast Awaiting requested review from LiranLast

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naomirookout @LiranLast @ElDuderinos